-
-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padding on the Google Icon in the button wrong #666
Comments
I'm having the same issue. I tried adding padding manually and centering the button, but was not able to fix the issue |
These native buttons are provided by the underneath library we have built our wrapper which in this case is (https://developers.google.com/identity/sign-in/android/). Has anyone tried to debug or tried more recent google sign in library version? |
I have this problem as well even with example project. I have Galaxy S8, and if I lower it's resolution from default WQHD+ to FHD, bug disappears. |
Also I have tried upgrading to googlePlayServicesAuthVersion = "17.0.0" (and thus support 28 with androidx stuff), but problem is not fixed |
I've tried to create Android native project with this button, and still have this issue. Thus, it's an issue with Android SDK. Solution can be to draw the button on your own, or use code similar to this, and alter layout's properties in runtime:
|
I've resolved it with my fork: https://github.com/nshaposhnik/react-native-google-signin/tree/padding_fix , although as you can see it's a hack, and it hardcodes button to SIZE_STANDARD/COLOR_AUTO. Also I've changed it to not use AndroidX stuff, so pls make sure to revert that commit for RN 0.60 and newer. |
I'm still having trouble with this. Has anyone found a solution beyond the hack that @nshaposhnik mentioned? |
Same issue when use it in android, showing me padding in android studio preview, but in real device, padding gone, any solution yet? I end up cutomized an button to replace it |
hello, I just tested on v7 and the padding seems okay to me. If anything, having your custom sign in button seems like a good idea too. Please open a new issue if the problem persists. |
The padding in the left hand side of the Google Icon is wrong for me on all button sizes apart from purely 'Icon' which works fine.
Steps to Reproduce
Copy the code for the button on the front page into the layout.
Expected Behavior
Icon should be evenly padded.
Actual Behavior
It isn't. See above picture
Environment
Android, real device.
The text was updated successfully, but these errors were encountered: