fix: wrong types path (#1554)

[xgenem]

Fix for Cannot find module 'react-native-image-picker' or its corresponding type declarations. #1554

Motivation (required)

What existing problem does the pull request solve?

This fixes the issue 'Cannot find module 'react-native-image-picker' or its corresponding type declarations.' #1554

Test Plan (required)

Tested fine after changing types path.

[Johan-dutoit]

Can you share your tsconfig setup (along with whatever other relevant setup), as I'm not experiencing this issue.

[xgenem]

I have a feeling that it is eslint's default configuration that showed this warning. But here's my tsconfig file and .eslintrc.json

{
  "compilerOptions": {
    "baseUrl": ".",
    "allowJs": true,
    "allowSyntheticDefaultImports": true,
    "jsx": "react-native",
    "lib": ["dom", "esnext"],
    "moduleResolution": "node",
    "noEmit": true,
    "skipLibCheck": true,
    "resolveJsonModule": true,
    "strict": true
  },
  "include": ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx"],
  "exclude": [
    "node_modules",
    "babel.config.js",
    "jest.config.js",
    "**/*.test.ts",
    "**/*.test.tsx"
  ]
}

{
  "extends": [
    "@react-native-community",
    "plugin:import/errors",
    "plugin:import/warnings",
    "plugin:import/typescript"
  ],
  "parser": "@typescript-eslint/parser",
  "plugins": ["@typescript-eslint", "import"],
  "overrides": [
    {
      "files": ["__mocks__/**/*.ts", "__mocks__/**/*.tsx"],
      "env": {
        "jest": true
      }
    }
  ],
  "settings": {
    "import/ignore": ["node_modules/react-native/index\\.js$"],
    "import/extensions": [".js", ".jsx", ".ts", ".tsx"],
    "import/order": [
      "error",
      {
        "groups": ["builtin", "external", "internal"],
        "pathGroups": [
          {
            "pattern": "react",
            "group": "external",
            "position": "before"
          },
          {
            "pattern": "@moxie/**",
            "group": "internal",
            "position": "after"
          }
        ],
        "pathGroupsExcludedImportTypes": ["react"],
        "newlines-between": "always",
        "alphabetize": {
          "order": "asc",
          "caseInsensitive": true
        }
      }
    ]
  },
  "rules": {
    "react-native/no-unused-styles": "error",
    "react-native/sort-styles": ["error", "asc"],
    "react-hooks/exhaustive-deps": "warn",
    "import/no-unresolved": "off",
    "import/namespace": "off",
    "react/jsx-sort-props": [
      "error",
      {
        "ignoreCase": true
      }
    ],
    "@typescript-eslint/no-unused-vars": "off"
  }
}

Curious if it matters, there's no src directory inside lib/typescript. Shouldn't it be an obvious fix?

[Johan-dutoit]

@xgenem good point about there being no src directory inside the lib/typescript folder.

Having a look at the history, it was changed away from this PR's change to include src.

Let me investigate a bit more.

[Johan-dutoit]

When I build the package locally, it does have lib/typescript/src/index.ts:

When viewing the package via my node_modules (where I install via npm), it doesn't include the src folder:

Nor is it included on unpkg: https://unpkg.com/browse/react-native-image-picker@3.1.3/lib/typescript/

[Johan-dutoit]

The folder still existed in 3.1.1. The only real change I can think of then was CI deployments, as no relevant code changed.

[Johan-dutoit]

LGTM

[xgenem]

Thanks! I find it weird. Thanks for staying on top of this.

[Johan-dutoit]

🎉 This PR is included in version 3.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀