fix(types): correct error code for others #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mardikarifqi
changed the title
|
@Johan-dutoit LGTM |
Johan-dutoit
approved these changes
Apr 23, 2021
Johan-dutoit
changed the title
Johan-dutoit
pushed a commit
that referenced
this pull request
Apr 23, 2021
## [3.3.3](v3.3.2...v3.3.3) (2021-04-23) ### Bug Fixes * **types:** correct error code for others ([#1668](#1668)) ([458d60e](458d60e))
|
🎉 This PR is included in version 3.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Cool! Thanks for staying on top of this. 😀 |
rupa982
added a commit
to rupa982/react-native-image-picker
that referenced
this pull request
Jun 11, 2021
## [3.3.3](react-native-image-picker/react-native-image-picker@v3.3.2...v3.3.3) (2021-04-23) ### Bug Fixes * **types:** correct error code for others ([#1668](react-native-image-picker/react-native-image-picker#1668)) ([458d60e](react-native-image-picker/react-native-image-picker@458d60e))
MattDennyir
pushed a commit
to MattDennyir/react-native-image-picker
that referenced
this pull request
Oct 19, 2022
## [3.3.3](react-native-image-picker/react-native-image-picker@v3.3.2...v3.3.3) (2021-04-23) ### Bug Fixes * **types:** correct error code for others ([#1668](react-native-image-picker/react-native-image-picker#1668)) ([e1f82f3](react-native-image-picker/react-native-image-picker@e1f82f3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please read these instructions carefully:
masterbranch, NOT a "stable" branch.Motivation (required)
What existing problem does the pull request solve?
I've noticed a mistake on the types.ts file at
ErrorCode. I believe that this value should beothersinstead ofother?Test Plan (required)
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.
If you have added code that should be tested, add tests.