Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: OnRequestPermissionsResultCallback #168

Closed
garrett-kl opened this issue Apr 12, 2016 · 5 comments
Closed

android: OnRequestPermissionsResultCallback #168

garrett-kl opened this issue Apr 12, 2016 · 5 comments

Comments

@garrett-kl
Copy link

Android 6+ (M) permission changes; permissions for the camera and media from the manifest aren't always granted and shouldn't be assumed.

Possible to implement OnRequestPermissionsResultCallback in react-native-image-picker? In the meantime there is a work around: wrapping calls into react-native-image-picker with custom permission checks.

@yfuks
Copy link
Contributor

yfuks commented Apr 12, 2016

We can make a custom permission check for sure.
Thanks for the info !

Will do it.

@yfuks
Copy link
Contributor

yfuks commented Apr 13, 2016

Done in 0.18.13 :)

@yfuks yfuks closed this as completed Apr 13, 2016
@yfuks
Copy link
Contributor

yfuks commented Apr 18, 2016

Ok not done
I read that wrong, will do it soon :)

@yfuks yfuks reopened this Apr 18, 2016
@marcshilling
Copy link
Contributor

I don't think it should be the responsibility of individual libraries to check permissions. If you're adding a library that accesses the camera, that's on you to add to your own Manifest file.

@johnculviner
Copy link

@marcshilling this isn't handled solely in the Manifest file anymore for APK 23+ it is to be requested and handled at runtime. I think this is becoming increasingly relevant as everyone gets newer phones and you compile for APK 23+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants