-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make REQUEST_LAUNCH codes public #1713
Conversation
Tell us how this hook works, why do you require request codes? The best thing would be just fork this library, make changes and use it. Since this change is simple we might consider it, but I don't think its right. Since its internal code we will refactor it any time as it requires, so best thing is you just fork it. Already in latest versions some of the request codes are changed after you created this PR. |
Thanks for checking this out Raviraj. Our hook does some native processing on the image after it's picked. I understand that version changes mean the request codes can change, isn't it fair to let consumers handle that change in their code if they consume the request codes directly? IMO this is just extending functionality that consumers can opt to use. Cheers |
ok. Just add a comment why it is public, simple one liner will do above the code. @Johan-dutoit LGTM |
# [3.8.0](v3.7.0...v3.8.0) (2021-05-21) ### Features * **android:** expose REQUEST_LAUNCH codes ([#1713](#1713)) ([b110113](b110113))
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [3.8.0](react-native-image-picker/react-native-image-picker@v3.7.0...v3.8.0) (2021-05-21) ### Features * **android:** expose REQUEST_LAUNCH codes ([#1713](react-native-image-picker/react-native-image-picker#1713)) ([b110113](react-native-image-picker/react-native-image-picker@b110113))
# [3.8.0](react-native-image-picker/react-native-image-picker@v3.7.0...v3.8.0) (2021-05-21) ### Features * **android:** expose REQUEST_LAUNCH codes ([#1713](react-native-image-picker/react-native-image-picker#1713)) ([3173185](react-native-image-picker/react-native-image-picker@3173185))
Thanks for submitting a PR! Please read these instructions carefully:
master
branch, NOT a "stable" branch.Motivation (required)
Thanks in advance for taking a look. The product I work on uses react-native-image-picker. We would like to hook directly into these REQUEST_LAUNCH codes, but newer versions of this package don't expose them publicly anymore. I looked at the change that took them from public to private, and there didn't seem to be an explicit reason for the change. This change just makes them public again.
Test Plan (required)
Just a minor change to make it easier for consuming apps to use these codes. Just making the 4 codes public.