Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gif returning as jpeg on android #1764

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

S0ngfu
Copy link
Contributor

@S0ngfu S0ngfu commented Jun 29, 2021

Thanks for submitting a PR! Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the master branch, NOT a "stable" branch.

Motivation (required)

Add support to gif file.

What existing problem does the pull request solve?

Will solve issue #1625

Test Plan (required)

I have tested on my phone and the gif is returning as expected with the image/gif type

@Johan-dutoit
Copy link
Collaborator

I'm happy to merge this once we know the state of iOS as well (asked in the issue linked).

@S0ngfu
Copy link
Contributor Author

S0ngfu commented Jul 9, 2021

I responded in the issue but I encountered this issue only on Android while developing. on iOS gif are okay

@Johan-dutoit Johan-dutoit linked an issue Jul 13, 2021 that may be closed by this pull request
@Johan-dutoit Johan-dutoit merged commit aaef8f3 into react-native-image-picker:main Jul 13, 2021
Johan-dutoit pushed a commit that referenced this pull request Jul 13, 2021
## [4.0.5](v4.0.4...v4.0.5) (2021-07-13)

### Bug Fixes

* gif returning as jpeg on android ([#1764](#1764)) ([aaef8f3](aaef8f3))
@Johan-dutoit
Copy link
Collaborator

🎉 This PR is included in version 4.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

MattDennyir pushed a commit to MattDennyir/react-native-image-picker that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] GIF coming as JPEG type
2 participants