fix: assets is actually optional #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typings are incorrect, and will cause potentially crashing apps if code is implemented incorrectly :-).
|
I do not see a |
Johan-dutoit
approved these changes
Jul 15, 2021
Johan-dutoit
pushed a commit
that referenced
this pull request
Jul 15, 2021
## [4.0.6](v4.0.5...v4.0.6) (2021-07-15) ### Bug Fixes * mark assets as optional ([#1772](#1772)) ([6169753](6169753))
|
🎉 This PR is included in version 4.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MattDennyir
pushed a commit
to MattDennyir/react-native-image-picker
that referenced
this pull request
Oct 19, 2022
## [4.0.6](react-native-image-picker/react-native-image-picker@v4.0.5...v4.0.6) (2021-07-15) ### Bug Fixes * mark assets as optional ([#1772](react-native-image-picker/react-native-image-picker#1772)) ([4608d0a](react-native-image-picker/react-native-image-picker@4608d0a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typings are incorrect, and will cause potentially crashing apps if code is implemented incorrectly :-).
Thanks for submitting a PR! Please read these instructions carefully:
masterbranch, NOT a "stable" branch.Motivation (required)
The typings are incorrect, caused a bug in our production app.
What existing problem does the pull request solve?
See Motivation
Test Plan (required)
Implement gallery picker, cancel picking see no assets if you log or try to use the field
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.
If you have added code that should be tested, add tests.