Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): 🐛 apply quality to both recordings and image picking #1776

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

Johan-dutoit
Copy link
Collaborator

Fixes GH-1775

Copy link

@adrienfloor adrienfloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could really use that ! Looks good to me 👍🏼

@Johan-dutoit
Copy link
Collaborator Author

@Liqiankun can you confirm it's working?

Copy link

@danniellabot danniellabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on repo by adding PR as dependency to replace v4.0.6. In package.json
dependency: {
....,
"react-native-image-picker": "github:react-native-image-picker/react-native-image-picker#pull/1776/head",
}

@Johan-dutoit Johan-dutoit merged commit de1ba82 into main Sep 21, 2021
Johan-dutoit pushed a commit that referenced this pull request Sep 21, 2021
## [4.1.1](v4.1.0...v4.1.1) (2021-09-21)

### Bug Fixes

* **video:** 🐛 apply quality to both recordings and image picking ([#1776](#1776)) ([de1ba82](de1ba82))
@Johan-dutoit
Copy link
Collaborator Author

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

MattDennyir pushed a commit to MattDennyir/react-native-image-picker that referenced this pull request Oct 19, 2022
@Johan-dutoit Johan-dutoit deleted the fix/GH-1775 branch June 20, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants