feat(ios): return fileSize of video on iOS #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Johan-dutoit Please merge the improvement |
|
My concern with merging this
I'm happy with android being skipped (for now) in favour of the docs saying video only for ios |
|
@Johan-dutoit thanks for the feedback, I've updated the docs to reflect the changes to the API 🙏 |
Johan-dutoit
approved these changes
Nov 10, 2021
Johan-dutoit
pushed a commit
that referenced
this pull request
Nov 10, 2021
# [4.2.0](v4.1.2...v4.2.0) (2021-11-10) ### Features * **ios:** return fileSize of video on iOS ([#1848](#1848)) ([fb85cfd](fb85cfd))
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MattDennyir
pushed a commit
to MattDennyir/react-native-image-picker
that referenced
this pull request
Oct 19, 2022
# [4.2.0](react-native-image-picker/react-native-image-picker@v4.1.2...v4.2.0) (2021-11-10) ### Features * **ios:** return fileSize of video on iOS ([#1848](react-native-image-picker/react-native-image-picker#1848)) ([f85044e](react-native-image-picker/react-native-image-picker@f85044e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please read these instructions carefully:
mainbranch, NOT a "stable" branch.Motivation (required)
Helps when validating a video a user has selected and helps to know if you need to optimize the video based on its file size
Test Plan (required)