feat(api): added methods to launch the image picker and camera as promise #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 15, 2021 12:39
Johan-dutoit
approved these changes
Nov 15, 2021
Johan-dutoit
pushed a commit
that referenced
this pull request
Nov 15, 2021
# [4.3.0](v4.2.1...v4.3.0) (2021-11-15) ### Features * **api:** added methods to launch the image picker and camera as promise ([#1873](#1873)) ([fde6838](fde6838))
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MattDennyir
pushed a commit
to MattDennyir/react-native-image-picker
that referenced
this pull request
Oct 19, 2022
# [4.3.0](react-native-image-picker/react-native-image-picker@v4.2.1...v4.3.0) (2021-11-15) ### Features * **api:** added methods to launch the image picker and camera as promise ([#1873](react-native-image-picker/react-native-image-picker#1873)) ([7e08016](react-native-image-picker/react-native-image-picker@7e08016))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch, NOT a "stable" branch.Motivation (required)
Easier API for those who want to work with promises instead of callbacks. I have found myself moving 'promisifying' code across multiple projects which use this library.
Test Plan (required)
New additions so only basic testing is needed as there is no risk of regression. We have ran tests within out application from our fork: https://github.com/Qeepsake/react-native-image-picker