feat(metadata): added width, height and datetime to video for iOS and Android #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johan-dutoit
approved these changes
Jan 4, 2022
Johan-dutoit
pushed a commit
that referenced
this pull request
Jan 4, 2022
# [4.7.0](v4.6.1...v4.7.0) (2022-01-04) ### Features * **metadata:** added width, height and datetime to video for iOS and Android ([#1891](#1891)) ([1394c23](1394c23))
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MattDennyir
added a commit
to MattDennyir/react-native-image-picker
that referenced
this pull request
Oct 19, 2022
# [4.7.0](react-native-image-picker/react-native-image-picker@v4.6.1...v4.7.0) (2022-01-04) ### Features * **metadata:** added width, height and datetime to video for iOS and Android ([#1891](react-native-image-picker/react-native-image-picker#1891)) ([6911430](react-native-image-picker/react-native-image-picker@6911430))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following properties to both Android and iOS for video:
NOTE: I introduced and ImageMetadata class and a Metadata parent class which can be used to extend metadata on images and videos going forward, and should make it easier to add stuff such as returning
long/lat. Will follow up this work sometime in the future and move stuff like Image orientation / dimensions to be accessed via the Exif class.Tested on our production application both iOS and Android.