Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): actions being saved when open launchImageLibrary #1928

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

arisyo13
Copy link
Contributor

@arisyo13 arisyo13 commented Jan 27, 2022

Thanks for submitting a PR! Please read these instructions carefully:

What existing problem does the pull request solve?

Action popup always show when picking up an image.
When two or more image library apps are installed in users device, then this action popup contains those apps and ask us which one to use. Normally Android takes care of this and asks if you want to save your option.
Function createChooser always enforces this action to being taken.

Here is an example of it
Screenshot 2022-01-25 at 23 53 29

And here is how it gets when removing createChooser function
Screenshot 2022-01-27 at 15 17 55

@arisyo13 arisyo13 changed the title fix actions being to be saved when open launchImageLibrary fix actions being saved when open launchImageLibrary Jan 27, 2022
Copy link
Collaborator

@lukebrandonfarrell lukebrandonfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukebrandonfarrell lukebrandonfarrell changed the title fix actions being saved when open launchImageLibrary fix(android): actions being saved when open launchImageLibrary Jan 28, 2022
@lukebrandonfarrell lukebrandonfarrell merged commit bcae866 into react-native-image-picker:main Jan 28, 2022
Johan-dutoit pushed a commit that referenced this pull request Jan 28, 2022
## [4.7.3](v4.7.2...v4.7.3) (2022-01-28)

### Bug Fixes

* **android:** actions being saved when open launchImageLibrary ([#1928](#1928)) ([bcae866](bcae866))
@Johan-dutoit
Copy link
Collaborator

🎉 This PR is included in version 4.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@slolkunchik
Copy link

slolkunchik commented Jul 12, 2022

Johan-dutoit it helped just for Android 11, not working for Android 10 and some samsung devices on Android 12

@fadhlinp
Copy link

fadhlinp commented Oct 17, 2022

Hi @slolkunchik , did you solve this problem?

MattDennyir added a commit to MattDennyir/react-native-image-picker that referenced this pull request Oct 19, 2022
@pavelustenko
Copy link

pavelustenko commented Oct 5, 2023

Still facing this issue until assigning default gallery app.
When "Use Once" is selected I always getting didCancel: true after image selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants