-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new PhotoPicker API for Android 13 Teramisu #1955
feat: add new PhotoPicker API for Android 13 Teramisu #1955
Conversation
android/build.gradle
Outdated
compileSdkVersion "android-Tiramisu" | ||
|
||
defaultConfig { | ||
minSdkVersion 21 | ||
targetSdkVersion rootProject.ext.targetSdkVersion | ||
targetSdkVersion "Tiramisu" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I agree with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is not a good idea
Great idea getting ahead with this PR. Barring the comment, the changes seem decent. |
6d3a543
to
7c31ec8
Compare
Android 13 hits Platform stability and as such, I have updated the sdk versions to the stable version. After you have confirm the feature on pre Android 13 and a Android 13 device/emulator, then feel free to merge it. |
7c31ec8
to
f9f8bb8
Compare
@Johan-dutoit given the above, can we have another round of PR review? I also agree it might be early to publish to stable channel, but we can use UPD: tested with installing @vincent-paing repo directly - works fine on Emulator with zero changes to the code base (see video) build.gradle
|
Given the fact that Android 13 is now available on Pixel devices, it would be great if this change is available in the next release for an upgrade. |
# [4.9.0](v4.8.5...v4.9.0) (2022-08-22) ### Features * add new PhotoPicker API for Android 13 Teramisu ([#1955](#1955)) ([28aa402](28aa402))
🎉 This PR is included in version 4.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [4.9.0](react-native-image-picker/react-native-image-picker@v4.8.5...v4.9.0) (2022-08-22) ### Features * add new PhotoPicker API for Android 13 Teramisu ([#1955](react-native-image-picker/react-native-image-picker#1955)) ([f8651d6](react-native-image-picker/react-native-image-picker@f8651d6))
Quick question though, it seems that this new API no longer grants access to every folders unlike before. |
master
branch, NOT a "stable" branch.Motivation (required)
Android 13 (codenamed Teramisu) introduces a new Photo Picker API that doesn't require the app to access full media libraries. Going forward, the photo picker will be the recommended way to access the user’s photos and videos. It also provides the API to select a specific amount of image/video to be selected instead of any number.
Test Plan (required)
0
,1
and3
values forselectionLimit
to see if it correctly handles max, one and certain amount of limit cases.(Currently there is known bug where Android 13 emulator does not return correct SDK_INT, so you might need to remove the if/else check for OS version to test it)
NOTE: It might be too early to merge this PR, this is just a preemptive PR so that we can polish this and merge when Android 13 become stable