correctly handle orientation on android

[GiovanniVisentiniCasavo]

Thanks for submitting a PR! Please read these instructions carefully:

• [ x] Explain the motivation for making this change.
• [x ] Provide a test plan demonstrating that the code is solid.
• [x ] Match the code formatting of the rest of the codebase.
• [x ] Target the main branch, NOT a "stable" branch.

Motivation (required)

the width / height returned by the library is swapped if the image is on portrait mode on some device (tested with Sony zx1 compact, and see also in some samsung device)

this because the library do not look on the image orientation when computing the w/h this is a problem also if the set the maxHight/Width since you are currently compare maxWidth with height and maxHeight with width

fix #1901 #1689

Test Plan (required)

run the example app, take the photo on portrait, check that the height > width
take a photo on landscape and check that width > height

[VitoMars]

@Johan-dutoit I don't know who is actively working on this project, so I may have tagged the wrong person, but can you please merge this pull request?

[ulpcan]

We need this change immediately!

[VitoMars]

Guys I urgently need this pull request to be merged, still today in many devices if you take a vertical photo width and height are reversed. Could any of the project admins please respond? @Johan-dutoit

[VitoMars]

@vorjdux @marcshilling @yfuks @janicduplessis @rusfearuth @haitaoli @ravirajn22 @charpeni @janicduplessis @pedro

[VitoMars]

We need this change immediately!

@ulpcan
I managed to solve the problem by using the "react-native-image-size" library to understand the image orientation and fix the problem.. (Although it's a bad solution to use another library to fix the bug of this library) .
I tell you the solution I made to solve the problem if no one answers here

this is how i solved it:

Imports:

import { launchCamera } from 'react-native-image-picker';
import ImageSize from 'react-native-image-size';

launchCamera:

 launchCamera(options, response => {
     if (response.didCancel) {
       console.log('Image selection cancelled');
     } else if (response.errorCode) {
       console.log(
         'Error selecting images:',
         response.errorMessage,
       );
     } else {
       const { uri, fileName, type, width, height } = response.assets[0];
       const { rotation } = await ImageSize.getSize(uri);

       const isVertical = rotation === 90 || rotation === 270;

       const normalizedWidth = isVertical ? height : width;
       const normalizedHeight = isVertical ? width : height;
     }
   });

[xaiamov]

@GiovanniVisentiniCasavo, thank you very much for the patch. Worked for me with the patch-package.

[GiovanniVisentiniCasavo]

thanks @xaiamov
@Johan-dutoit do you have intention to merge it? if yes I can resolve the conflict, otherwise you can close this pr and explain way you don't accept this code.

[Johan-dutoit]

thanks @xaiamov
@Johan-dutoit do you have intention to merge it? if yes I can resolve the conflict, otherwise you can close this pr and explain way you don't accept this code.

Hi, if this genuinely solves an issue, I'll happily merge it. If you can resolve conflicts, I'll run it on the test app and take it from there.

[GiovanniVisentiniCasavo]

@Johan-dutoit rebase done!

[GiovanniVisentiniCasavo]

@Johan-dutoit can you merge it?

[Johan-dutoit]

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀