Added assetRepresentationMode prop #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naWka
previously approved these changes
Feb 16, 2023
marcshilling
approved these changes
May 24, 2023
dwosk
approved these changes
May 24, 2023
dabrad26
approved these changes
May 24, 2023
Johan-dutoit
approved these changes
May 26, 2023
Johan-dutoit
pushed a commit
that referenced
this pull request
May 26, 2023
# [5.4.0](v5.3.1...v5.4.0) (2023-05-26) ### Features * **video:** Added assetRepresentationMode prop ([#2083](#2083)) ([f2044ee](f2044ee))
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
By default there is no way to change the way assets are processed. If the user selects a lot of video files, then the default processing method will greatly affect the performance of the application.
loadFileRepresentationtakes a long time and gives the user a bad user experience. If the developer can choose the processing mode, then he will be able to more flexibly approach the issue of performance and file processing.Available processing modes:
https://developer.apple.com/documentation/photokit/phpickerconfiguration/assetrepresentationmode
Additional info:
https://developer.apple.com/documentation/photokit/phpickerconfiguration/3670270-preferredassetrepresentationmode/
Test Plan (required)
No plan, just add some PHPicker configuration option