Add fallback to getting extension from filename #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j-piasecki keen to update the PR to also grab the filename from the content resolver? |
|
@Johan-dutoit could you clarify what you mean? It already gets the filename via |
|
Hah. @j-piasecki Apologies for not being clear. I was suggesting to use the filename from the |
|
Actually, I'll make the change once this PR is merged. Thanks! |
Johan-dutoit
approved these changes
Sep 7, 2023
Johan-dutoit
pushed a commit
that referenced
this pull request
Sep 7, 2023
# [5.7.0](v5.6.1...v5.7.0) (2023-09-07) ### Features * **filename:** add fallback to getting extension from filename ([#2118](#2118)) ([2c13085](2c13085))
|
🎉 This PR is included in version 5.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please read these instructions carefully:
mainbranch, NOT a "stable" branch.Motivation (required)
In some cases the
getExtensionFromMimeTypemay returnnull, in which case the generated file would lack the extension. This PR adds fallback to rely on the extension when it happens.Test Plan (required)
I wasn't able to make a reproducible example to showcase the problem, however, it emerged during the migration of the Expensify app to the new architecture. We've been using the patch for a while and didn't see any problems with it.