Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃悰] Pod install fail with error "No package name found" #2156

Open
poojesh-ws opened this issue Jun 21, 2023 · 4 comments
Open

[馃悰] Pod install fail with error "No package name found" #2156

poojesh-ws opened this issue Jun 21, 2023 · 4 comments

Comments

@poojesh-ws
Copy link

poojesh-ws commented Jun 21, 2023

Description

When I am executing pod install for ios the install fails with the following error
No package name found. Found errors in ../react-native-image-picker/android/src/main/AndroidManifest.xml.
The package name was recently removed 4584d7b

How to repeat issue and example

"react-native": "0.70.8",
"react-native-image-picker": "^5.3.1",

Additional Information

  • Image Picker version: [^5.3.1]
  • React Native version: [0.70.8]
  • Platform: [iOS]
  • Development Operating System: [MacOS]
@ablack34
Copy link

Hey,

I am am facing a similar issue.

When I run "npx.cmd --quiet --no-install react-native config" I am getting an error, "Failed to build the app: No package name found."

I am using "react-native-image-picker": "^5.0.1",

@poojesh-ws
Copy link
Author

Hey,

I am am facing a similar issue.

When I run "npx.cmd --quiet --no-install react-native config" I am getting an error, "Failed to build the app: No package name found."

I am using "react-native-image-picker": "^5.0.1",

For now you can give the previous version till the time the fix is not pushed. This version v5.4.2 should work since since it has the package name in the xml.
Just change the version from "^5.0.1" to "5.4.2" and check whether it works. I am not an expert though. Would be great if other community members could comment on this

@mohan1361
Copy link

mohan1361 commented Jun 23, 2023

Just change the version from "^5.0.1" to "5.4.2" and it's working for me.
5.6.0 not working and there is a missing package name.

@tj-mc
Copy link

tj-mc commented Dec 11, 2023

In my case, I'm using expo-image-picker, and it suffers from the same problem on Expo 46 ejected.
I applied this patch to fix this issue.

diff --git a/node_modules/expo-image-picker/android/src/main/AndroidManifest.xml b/node_modules/expo-image-picker/android/src/main/AndroidManifest.xml
index 9ea2a9d..5f64d0f 100644
--- a/node_modules/expo-image-picker/android/src/main/AndroidManifest.xml
+++ b/node_modules/expo-image-picker/android/src/main/AndroidManifest.xml
@@ -1,4 +1,4 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+<manifest package="expo.modules.imagepicker" xmlns:android="http://schemas.android.com/apk/res/android"
   xmlns:tools="http://schemas.android.com/tools">
   <!-- Required for picking images from camera directly -->
   <uses-permission android:name="android.permission.CAMERA" />

An explanation can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants