fix(android): support rn version 0.68 #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading react-native-image-picker from 5.4.2 to 5.5.0 resulted in my app no longer building because of the following issue: `error: cannot find symbol new ImagePickerPackage()` This issue was introduced here: react-native-image-picker@4584d7b My stack: Using react-native 0.68.2 Gradle 7.3.1 buildToolsVersion 33 compileSdkVersion 33 targetSdkVersion 33 minSdkVersion 24 kotlinVersion 1.7.0
This was referenced Aug 16, 2023
Johan-dutoit
pushed a commit
that referenced
this pull request
Aug 16, 2023
## [5.6.1](v5.6.0...v5.6.1) (2023-08-16) ### Bug Fixes * **android:** support rn version 0.68 ([#2193](#2193)) ([58aeb06](58aeb06))
|
🎉 This PR is included in version 5.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
v5.6.0 is no longer building for React-Native 0.68.
After upgrading react-native-image-picker from 5.4.2 to 5.5.0 my app no longer builds because of the following issue:
error: cannot find symbol new ImagePickerPackage()This issue was introduced here:
4584d7b
This pr will fix these bugs :
Test Plan
Build android
My stack
Using react-native 0.68.2
Gradle 7.3.1
buildToolsVersion 33
compileSdkVersion 33
targetSdkVersion 33
minSdkVersion 24
kotlinVersion 1.7.0
Temp workaround
Use
patch-packagewith the following update