Make react-native-image-picker compatible with use_frameworks #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
commented
Nov 17, 2023
| s.dependency "RCTTypeSafety" | ||
| s.dependency "ReactCommon/turbomodule/core" | ||
| if defined?(install_modules_dependencies) != nil | ||
| install_modules_dependencies(s) |
There was a problem hiding this comment.
this function has been defined in 0.70 and allows library maintainers not to care about the internals of React Native. We are going to handle all the dependencies on the internal pods ourselves and, as long as you use this function, you don't have to care about them.
Johan-dutoit
previously approved these changes
Nov 23, 2023
francesco-clementi-92
approved these changes
Nov 28, 2023
|
Can someone approve this PR? This solution works. (check on my local project) |
Johan-dutoit
approved these changes
Dec 4, 2023
Johan-dutoit
pushed a commit
that referenced
this pull request
Dec 4, 2023
# [7.1.0](v7.0.3...v7.1.0) (2023-12-04) ### Features * add use_frameworks compatibility ([#2242](#2242)) ([6cb36f4](6cb36f4))
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please read these instructions carefully:
mainbranch, NOT a "stable" branch.Motivation (required)
react-native-image-picker is not compatible with React Native 0.72, when use_frameworks! is enabled.
It fails to load a module, because it is mixing Swift and Objective-C import styles
Given that React Native is a C++ project and Swift and C++ do not like each other, the current setup is dangerous and can break easily.
This PR updates the podspec introducing the
install_modules_dependenciesfunction when defined to relieve the burden of properly handling the React Native internals from the library.It also adds the dependency to the Apple's MobileCoreServices, so that we ca import it using the proper Objective-C syntax.
And then uses the right syntax to import the module.
Test Plan (required)
The example app is on 0.71, so the test is limited.
You can run the test by:
and then build and run from Xcode. You'll see the app building successfully.
I also created a new app using React Native 0.72, installed the library with
yarn add react-native-image-pickerand run the same commands.Before applying the patch in this PR, it was failing.
After the patch, it was building successfully.