Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Google Maps liteMode #300

Closed
jonestheguitar opened this issue Jun 16, 2016 · 5 comments
Closed

Support for Google Maps liteMode #300

jonestheguitar opened this issue Jun 16, 2016 · 5 comments

Comments

@jonestheguitar
Copy link

Can we have support for liteMode? - this will allow maps to be used in lists etc. on Android.

@jrichardlai has some changes for this https://github.com/lelandrichardson/react-native-maps/compare/master...jrichardlai:android-with-litemode?expand=1
which I'm now using in my fork (jonestheguitar@2d98d3f) but it would be good to make them generally available.

@christopherdro
Copy link
Collaborator

This looks good. Can either one of you put it together as a PR?

@jrichardlai
Copy link
Contributor

@jonesdar glad this worked well with you, did you encounter any issues? I didn't used it that much, I switched to the caching strategy coming from this branch #295. I will make a PR for liteMode if it worked fine for you.

@jrichardlai
Copy link
Contributor

jrichardlai commented Jun 22, 2016

@jonesdar thoughts on the fix?

@jonestheguitar
Copy link
Author

Works fine for me thanks!
Note that the changes in jonestheguitar@2d98d3f are more up-to-date than your original changes but a colleague tried to update to the latest version of react-native-maps recently and found some issues so there might be more adjustments needed.

@spikebrehm
Copy link

Closing with #546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants