Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest renderer for Maps SDK for Android in react-native-maps #4980

Closed
LVExMachina opened this issue Feb 21, 2024 · 7 comments
Closed
Labels
bug Something isn't working

Comments

@LVExMachina
Copy link

Summary

I received an email from Google Maps Platform stating that apps using the legacy renderer for Maps SDK for Android will be automatically updated to the new renderer starting in March 2024. The legacy renderer will be decommissioned in March 2025. I would like to know if the react-native-maps library is already compatible with the new renderer and, if so, which version is recommended.

The Google Maps Platform email specifies that apps built with Maps SDK for Android will be automatically updated to the new renderer on March 4, 2024. However, if the legacy renderer is manually specified in the settings, the update will be delayed until March 2025.

I would like to understand if the react-native-maps library is ready to handle the new renderer and which version I should use to ensure compatibility with the automatic Google update.

image

Reproducible sample code

I do not currently have sample code to show as the issue is about library compatibility and not a specific bug.
I do not have precise information on the steps to reproduce the issue as this is a preventive notice from Google Maps Platform.

Steps to reproduce

I do not currently have sample code to show as the issue is about library compatibility and not a specific bug.
I do not have precise information on the steps to reproduce the issue as this is a preventive notice from Google Maps Platform.

Expected result

I do not currently have sample code to show as the issue is about library compatibility and not a specific bug.
I do not have precise information on the steps to reproduce the issue as this is a preventive notice from Google Maps Platform.

Actual result

I do not currently have sample code to show as the issue is about library compatibility and not a specific bug.
I do not have precise information on the steps to reproduce the issue as this is a preventive notice from Google Maps Platform.

React Native Maps Version

1.7.1

What platforms are you seeing the problem on?

Android, iOS (Apple Maps)

React Native Version

0.72.10

What version of Expo are you using?

SDK 48

Device(s)

Not specific device

Additional information

No response

@LVExMachina LVExMachina added the bug Something isn't working label Feb 21, 2024
@Filippo39
Copy link
Contributor

Filippo39 commented Feb 21, 2024

The email states:

No action is recommended if your app already uses Maps SDK for Android v18.2.0 and does not specify a renderer during the initialization process.

From what I can see, starting from version v1.9.0, following the modification made in #4921, the Maps SDK for Android has been updated to version v18.2.0. Therefore, from that version onwards, we should be okay.

Note: If anyone, like myself, has defined playServicesVersion in their android/build.gradle, that value overrides the version used by react-native-maps.

It remains to be understood whether the second part of the sentence in the email:

...and does not specify a renderer during the initialization process.

is respected with v1.9.0, and if older versions will receive a patch or if we will all be forced to update.

@salah-ghanim
Copy link
Collaborator

@Filippo39 thanks for contributing, yes latest SDK version should have latest renderer enabled out of the box.

for couple of the previous versions calling MapView.enableLatestRenderer() should work as well.

@LVExMachina
Copy link
Author

Thank you!

@uzuntonev
Copy link

I am facing issues when calling enableLatestRenderer() . Custom Marker ( children warped in ) starts flickering.

Note: Passing prop tracksViewChanges={false} is not a solution because markers change dynamically and scale if selected. Passing this prop prevents any image changes

Running on

  • "react-native": "0.72.6"
  • "react-native-maps": "^1.7.1"

@GabrieleMazzola
Copy link

I am facing issues when calling enableLatestRenderer() . Custom Marker ( children warped in ) starts flickering.

Note: Passing prop tracksViewChanges={false} is not a solution because markers change dynamically and scale if selected. Passing this prop prevents any image changes

Running on

  • "react-native": "0.72.6"
  • "react-native-maps": "^1.7.1"

I also experienced the same issue, and having dynamic markers I could not rely on tracksViewChanges={false}.

For now, I disabled the new renderer using googleRenderer={'LEGACY'} on my <MapView>. It should be okay for a year or so, we'll see what happens next.

@ryskin
Copy link

ryskin commented May 31, 2024

why it's closed? I'm still having this issue

@andrecrimb
Copy link

Still facing the same issue, will this issue be reopened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants