Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 7.3.1 Compatibility (or not?) #629

Closed
chrisknepper opened this issue Sep 29, 2016 · 3 comments
Closed

Xcode 7.3.1 Compatibility (or not?) #629

chrisknepper opened this issue Sep 29, 2016 · 3 comments

Comments

@chrisknepper
Copy link
Contributor

When attempting to build a project containing react-native-maps at the latest commit in master, be2e6b3, for iOS in Xcode 7.3.1, the build fails with the following error:

Cannot find protocol declaration for 'CAAnimationDelegate'

As I understand it, this is because CAAnimationDelegate was added to the iOS 10 SDK, which is only available in Xcode 8. However, as of the current version of react-native, 0.34, Xcode 7.3.1 can still be used to build to iOS, though I am unsure if this is officially supported.

I don't know if it's worth thinking about Xcode 7.x support, or maintaining Xcode 7.x support in react-native-maps, since it is an old version, but I thought it would be good to discuss it, so we can clarify this in the docs and avoid any confusion.

@rops
Copy link
Contributor

rops commented Oct 3, 2016

Had the same issue since we haven't officially switched to iOS 10/XCode 8.

Would it make sense to add something like this?

#if __IPHONE_OS_VERSION_MAX_ALLOWED < 100000
@interface SMCalloutView : UIView
#else
@interface SMCalloutView : UIView <CAAnimationDelegate>
#endif

This was added as of #548, hence cc-ing @gilbox @lelandrichardson

@warmwater
Copy link

I have countered the same issue, I am also using Xcode 7.3.1

@roysG
Copy link

roysG commented Oct 8, 2016

same for me, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants