feat: numberOfLines prop on iOS #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Naturalclar , there seems to be some flow error in CI, also there are merge conflicts. Let me know what should be fixed to make CI pass, I'll also resolve merge conflicts |
|
I think this needs to be accepted! |
Add multiline support for iOS picker. `numberOfLines` prop on iOS accepts integer value greater or equal to 1. Picker rows' height is based on that prop. **NOTE** in order to prevent multiline text being cut on leading and trailing edges on iOS 14, there is hardcoded horizontal padding of 20pts added to UILabel (Closes react-native-picker#212), potentially in future, it can be adjusted via `style` or `itemStyle` props
mateusz1913
force-pushed
the
feat/ios-number-of-lines
branch
from
5182cb2
to
62f12c9
Compare
|
👋 Fixed CI error and resolved merge conflicts |
Naturalclar
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
@mateusz1913 sorry for the late response, tested and it LGTM!
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiline support for iOS picker.
numberOfLinesprop on iOS accepts integer value greater or equal to 1.Picker rows' height is based on that prop.
NOTE in order to prevent multiline text being cut on leading and trailing edges on iOS 14, there is hardcoded horizontal padding of 20pts added to UILabel (Closes #212), potentially in future, it can be adjusted via
styleoritemStyleprops