feat: Allow using WinUI 3 Controls #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinUI 3 controls are in a separate namespace than system XAML. `react-native-windows` exports headers making it easier to target both, with the right control resolved based on user settings. This changes includes of System XAML to the aliased versions instead. It conditionally removes references to versioned System XAML interfaces as well. Mirrors the following patch in the RNW repo: https://github.com/microsoft/react-native-windows/blob/main/patches/%40react-native-picker%2Bpicker%2B2.1.0.patch
NickGerleman
changed the title
asklar
reviewed
Oct 25, 2021
|
The template library includes ExperimentalFeatures.props for us IIRC. This patch is what we're using in the repo right now for WinUI 3 Playground. |
|
Hmm, I don't see it being imported in the project. I will add the reference, as it is in the 0.65 template. Curious how this was resolving to WINUI 3 in the RNW repo 🤨. |
|
@asklar @Naturalclar could you take another look? |
asklar
approved these changes
Oct 28, 2021
|
lgtm |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinUI 3 controls are in a separate namespace than system XAML.
react-native-windowsexports headers making it easier to target both, with the right control resolved based on user settings.This changes includes of System XAML to the aliased versions instead. It conditionally removes references to versioned System XAML interfaces as well.
Mirrors the following patch in the RNW repo: https://github.com/microsoft/react-native-windows/blob/main/patches/%40react-native-picker%2Bpicker%2B2.1.0.patch