feat: Add placeholder support for Windows #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change brings parity with the react-native-windows 0.63 Picker implementation of not setting a default index for the picker: https://github.com/microsoft/react-native-windows/blob/0.63-stable/vnext/Microsoft.ReactNative/Views/PickerViewManager.cpp#L40 If we don't set the index to -1 (or default to 0) we the place holder text won't appear https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.combobox.placeholdertext?view=winrt-22000#remarks This change also adds placeholder text support for Windows only + an example to use it
Naturalclar
approved these changes
Mar 15, 2022
Naturalclar
changed the title
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings parity with the react-native-windows 0.63 Picker implementation of not setting a default index for the picker:
https://github.com/microsoft/react-native-windows/blob/0.63-stable/vnext/Microsoft.ReactNative/Views/PickerViewManager.cpp#L40
If we don't set the index to -1 (or due to defaulting to 0) the place holder text won't appear otherwise
https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.combobox.placeholdertext?view=winrt-22000#remarks
This change also adds placeholder text support for Windows only + an example to use it.