raw gravity added #397
Merged
raw gravity added #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
requested changes
Jul 20, 2021
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Could you remove that file and add .vscode to the gitignore?
| new RNSensor(reactContext, "RNSensorsMagnetometer", Sensor.TYPE_MAGNETIC_FIELD), | ||
| new RNSensor(reactContext, "RNSensorsBarometer", Sensor.TYPE_PRESSURE), | ||
| new RNSensor(reactContext, "RNSensorsOrientation", Sensor.TYPE_ROTATION_VECTOR) | ||
| new RNSensor(reactContext, "Gyroscope", Sensor.TYPE_GYROSCOPE), |
There was a problem hiding this comment.
Can you prefix them with RNSensors?
src/rnsensors.js
Outdated
| RNSensorsMagnetometer: MagnNative, | ||
| RNSensorsBarometer: BarNative, | ||
| RNSensorsOrientation: OrientNative, | ||
| Gyroscope: GyroNative, |
There was a problem hiding this comment.
This needs to stay prefixed
src/sensors.js
Outdated
| RNSensorsMagnetometer: MagnNative, | ||
| RNSensorsBarometer: BarNative, | ||
| RNSensorsOrientation: OrientNative, | ||
| Gyroscope: GyroNative, |
There was a problem hiding this comment.
This needs to stay prefixed
|
all are done and now we can merge it |
DanielMSchmidt
approved these changes
Jul 23, 2021
|
Awesome, thanks for your help! |
|
🎉 This PR is included in version 7.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kibolho
pushed a commit
to kibolho/react-native-sensors
that referenced
this pull request
Oct 7, 2023
* raw gravity added for android * raw gravity added for ios * prefixes * ignore vscode config * prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working to get the same for ios when user have gravity so linear acceleration can be calculated by
linearAcceleration = accelerometer - gravity