Android filename base64 is not working

[brunojs02]

Steps to reproduce

1. Create a react native project.
2. Install react native share lib (yarn add react-native-share).
3. Write a basic application to share an image in base64.

Expected behaviour

When I call Share.open({ filename: 'myimage', url: '...' }), I want that file exported to gmail with the filename passed to open method.

Actual behaviour

The actual filename is the current timestamp.

Environment

• 0.61.2
• Android 8.0 (emulator)

react-native-share

2.0.0

code example

// App.js
import React from 'react';
import {View, Button} from 'react-native';
import Share from 'react-native-share';
import {image} from './mock.json'; // image in base64

export default () => (
<View style={{flex: 1, alignItems: 'center', justifyContent: 'center'}}>
<Button title="Share" onPress={() => Share.open({filename: 'myfilename', url: image})} />

);

Link to repo (highly encouraged)

Project

[brunojs02]

Looking at the sources, i found the possible problem, in the repo the class ShareIntent has a method called getFileShare

String filename = null;
if (ShareIntent.hasValidKey("filename", options)) {
    filename = options.getString("filename");
}
if (ShareIntent.hasValidKey("type", options)) {
    return new ShareFile(options.getString("url"), options.getString("type"), filename, this.reactContext);
} else {
    return new ShareFile(options.getString("url"), filename, this.reactContext);
}

but on the version published on the npm, the source look like this

if (ShareIntent.hasValidKey("type", options)) {
    return new ShareFile(options.getString("url"), options.getString("type"), this.reactContext);
} else {
    return new ShareFile(options.getString("url"), this.reactContext);
 }

[jgcmarins]

@brunojs02 thanks for looking deeper.
Does it only happens on Android?

[brunojs02]

i haven't tested yet, i don't use base64 on iOS.

[brunojs02]

@jgcmarins when a new release will be available with this feature?

[jgcmarins]

is it ok on master branch?

[brunojs02]

Only work on shareSingle method.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and i will leave this open.

[stale]

Closing this issue after a prolonged period of inactivity. Fell free to reopen this issue, if this still affecting you.

[rrraymonde]

This issue has not been fixed, I still have the same problem as described in the first message.

[liplylie]

version 3.1.1 has a fix for this.

[matheuslimatc]

3.1.1 and 3.5.0 not working for me in IOs.