-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share PHAsset #634
Comments
Hello @RocKhalil, it should be possible. |
@jgcmarins I wrote a small hack for it right now (within the Maybe you can get inspired by this for the
I know that the code is not performance oriented, but I need to move on from this task and will get back to this one as soon as possible. |
@RocKhalil great to hear that. |
@jgcmarins I tried adding the above piece of code to
Now the issue is that If you can help me with this, I'll test the solution and create a PR asap. Thanks :-) |
@jgcmarins the previous answer had some issues (not sharing correctly), so I wrote a better fix for
This way, whoever is calling the API will only do: |
That's great. Does it makes sense to support PHAsset. I mean, does Apple is moving around to this type for URIs? |
@jgcmarins mainly yes. It will also give compatibility to share images retrieved from |
👍 I'm just in the process of extending the IG share (and stories) to also cater for ph:// urls too. |
This would be a great to rn-share. Do you need any help on that? |
Cheers! 👍🏻 I might to perhaps tighten up the Obj-C code as I don’t have lots of experience in it. I’ll get it working for what I’m doing and then put a PR together. Just want to get stories with stickers working again! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and i will leave this open |
Hey! Did this end up being merged into react-native-share? Can you share |
About
I'm trying to share images from my CameraRoll using
@react-native-community/react-native-share
and@react-native-community/cameraroll
Code Preview
This isn't the actual one, but works fine for demo purposes.
Question
On android, it's working perfectly. However, on iOS, we get from
photo.image.uri
aPHAsset
url of the asset.Right now, when the share dialog opens, we can't see the file that is being shared and we only see
001
which is the PHAsset's last file path.Is there any way to share the
ph://....
image or video directly ?The text was updated successfully, but these errors were encountered: