Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stop.tsx error TS2612: Property 'props' will overwrite the base property in 'Component<StopProps, {}, any>' #1777

Merged
merged 1 commit into from Jul 25, 2022
Merged

Fix Stop.tsx error TS2612: Property 'props' will overwrite the base property in 'Component<StopProps, {}, any>' #1777

merged 1 commit into from Jul 25, 2022

Conversation

sekoyo
Copy link
Contributor

@sekoyo sekoyo commented May 31, 2022 •
edited

Summary

Hi, not sure why this has props declared here (Component<StopProps, {}> handles that) and it results in a TS error (TS 4.7.2):

node_modules/react-native-svg/src/elements/Stop.tsx:8:3 - error TS2612: Property 'props' will overwrite the base property in 'Component<StopProps, {}, any>'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

8   props!: StopProps;
    ~~~~~

Found 1 error. Watching for file changes.

Test Plan

tsc passes but other lint/test tasks fail for unrelated reasons

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@sekoyo
Update Stop.tsx
2a03ff4 
Hi, not sure why this has props declared here (Component handles that) and it results in a TS error (TS 4.7.2):

```
node_modules/react-native-svg/src/elements/Stop.tsx:8:3 - error TS2612: Property 'props' will overwrite the base property in 'Component<StopProps, {}, any>'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

8   props!: StopProps;
    ~~~~~

Found 1 error. Watching for file changes.
```
@sekoyo sekoyo changed the title Update Stop.tsx Fix Stop.tsx error TS2612: Property 'props' will overwrite the base property in 'Component<StopProps, {}, any>' May 31, 2022
WoLewicki
WoLewicki approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution 🎉

@WoLewicki WoLewicki merged commit 211acf0 into software-mansion:main Jul 25, 2022
@mateusbra mateusbra mentioned this pull request Aug 10, 2022
Merged
91 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sekoyo @WoLewicki