fix: support opacity properly #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannojg
added a commit
to margelo/expensify-app-fork
that referenced
this pull request
Jan 9, 2024
HezekielT
pushed a commit
to HezekielT/App
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
/
Update the changelog
/
Provide an example of how to test the change
In the example app set the styles of a video component to opacity: 0.5. The whole video component should now be 50% visible. Without that change, only the video content would have 50% transparency while the video view itself would be a back background.
Focus the PR on only one area
✅
Describe the changes
Texture views are by default opaque. To enable styling the opacity of a video when using texture view we have to disable opaqueness.