Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove setNativeProps usage #3605

Conversation

KrzysztofMoch
Copy link
Collaborator

@KrzysztofMoch KrzysztofMoch commented Mar 25, 2024

Summary

Moved prop seek to VideoManager function as setNativeProps is deprecated
There will be separate PR for windows as we don't have VideoManager on it

Motivation

setNativeProps is deprecated and in order to make it work on Interop Layer I moved it to component reference function

Changes

  • Remove seek prop
  • Added seek function to VideoManager

Test plan

  • CI pass
  • Tested in basic example

src/Video.tsx Outdated Show resolved Hide resolved
@KrzysztofMoch KrzysztofMoch merged commit 0312afc into TheWidlarzGroup:master Mar 28, 2024
11 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/remove-set-naitve-props branch March 28, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants