Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix getLicense function's type definition #3606

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

YangJonghun
Copy link
Collaborator

@YangJonghun YangJonghun commented Mar 25, 2024

Summary

fix getLicense function's type definition

Motivation

fix getLicense function's type definition

Changes

Test plan

sync with type definition and native codes
@freeboub
Copy link
Collaborator

freeboub commented Mar 26, 2024

This change will introduce a breaking change, I think we can avoid it by changing declaration in ts ?
BTW, if we agree to introduce a breaking change, it would be better to put all props in an object ! can be planned for V7 if you want

@YangJonghun
Copy link
Collaborator Author

This change will introduce a breaking change, I think we can avoid it by changing declaration in ts ? BTW, if we agree to introduce a breaking change, it would be better to put all props in an object ! can be planned for V7 if you want

@freeboub
I don't want breaking change. so I revert previous commit and just fix type definition.
In my thoughts, If we need to change this function, getLicense function should take an object type argument as shown below.

{ spcBase64, contentId, licenseUrl, loadedLicenseUrl }

but it isn't neccesary.

@YangJonghun YangJonghun changed the title fix: reorder getLicense function's parameters fix: fix getLicense function's type definition Mar 26, 2024
@freeboub
Copy link
Collaborator

Thank you, let's follow up here: #3615

@freeboub freeboub merged commit 89ae843 into TheWidlarzGroup:master Mar 26, 2024
2 checks passed
@YangJonghun YangJonghun deleted the fix/on-get-license-fn branch March 31, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants