Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #35

Merged
merged 1 commit into from May 13, 2015
Merged

Documentation updates #35

merged 1 commit into from May 13, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2015

Add required step to the installation instructions after hitting the same problem from #1. Also removes a duplicate data property.

@ghost ghost changed the title Removing duplicate data property Add required installation step May 12, 2015
@ghost ghost mentioned this pull request May 13, 2015
@ghost ghost changed the title Add required installation step Documentation updates May 13, 2015
In order to use this native component the video resources must be
added to the project and bundled on build.

- Also remove a duplicate data property
- Fix linkrot in README and add Examples section
brentvatne added a commit that referenced this pull request May 13, 2015
@brentvatne brentvatne merged commit 5cbfc2f into TheWidlarzGroup:master May 13, 2015
@brentvatne
Copy link
Contributor

@jhabdas - Thanks! This should help people getting going with it 😄

@ghost
Copy link
Author

ghost commented May 13, 2015

Glad I could help. Mind tagging a 0.3.6 release and updating NPM? I'm currently forked due to build issues with Webpack and the dupe data property bugfix I snuck in with the doc updates.

@ghost
Copy link
Author

ghost commented May 13, 2015

Works great by the way! https://t.co/9XsWA4sgWb

@brentvatne
Copy link
Contributor

@jhabdas - thanks, bumped to 0.3.6 and pushed!

@brentvatne
Copy link
Contributor

@jhabdas - also, awesome to see it in use! 😄

@nicoara nicoara mentioned this pull request Nov 9, 2018
vhscom pushed a commit to vhscom/lumpen-radio that referenced this pull request Feb 19, 2022
Adds a looped video backdrop to app using react-native-video. Also in
this update:

- Fork react-native-video until TheWidlarzGroup/react-native-video/pull/35
- Update WebPack config to handle new module ES6/ES7 transpilation
- Add missing ignored module for roman01la/react-native-babel/pull/5
- Add AnyBar plug-in for Webpack
- Put project workspace under source control
- Update roadmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant