Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): read minSdkVersion from root project #314

Merged
merged 1 commit into from Apr 26, 2021
Merged

fix(android): read minSdkVersion from root project #314

merged 1 commit into from Apr 26, 2021

Conversation

keremoge
Copy link
Contributor

No description provided.

@safaiyeh
Copy link
Member

Appreciate the PR @keremoge

@safaiyeh safaiyeh merged commit 940f570 into react-native-voice:master Apr 26, 2021
safaiyeh pushed a commit that referenced this pull request Apr 26, 2021
@semantic-release-bot
chore(release): 3.1.2 [skip ci]
cfb3e28 
## [3.1.2](v3.1.1...v3.1.2) (2021-04-26)

### Bug Fixes

* **Android:** read minSdkVersion from root project ([#314](#314)) ([940f570](940f570))
@safaiyeh
Copy link
Member

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lecaro
Copy link

lecaro commented Apr 27, 2021

Hello! I'm having this issue with this new update... any suggestions, please please

FAILURE: Build failed with an exception.

  • Where:
    Build file '...\node_modules@react-native-voice\voice\android\build.gradle' line: 22

  • What went wrong:
    A problem occurred evaluating project ':react-native-voice_voice'.
    No signature of method: build_eqttlctslkgkjicqtt60194dp.android() is applicable for argument types: >(build_eqttlctslkgkjicqtt60194dp$_run_closure2) values: [build_eqttlctslkgkjicqtt60194dp$_run_closure2@5a5ac152]

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan >to get full insights.

  • Get more help at https://help.gradle.org

BUILD FAILED in 9s

@safaiyeh
Copy link
Member

@lecaro apologies, should have been released as a breaking change, will revert and re-release

safaiyeh added a commit that referenced this pull request Apr 27, 2021
@safaiyeh
Revert "fix(Android): read minSdkVersion from root project (#314)"
a0ca9a7 
This reverts commit 940f570.
@safaiyeh safaiyeh mentioned this pull request Apr 27, 2021
Merged
safaiyeh added a commit that referenced this pull request Apr 27, 2021
@safaiyeh
fix(Android): Revert "Read minSdkVersion from root project (#314)" (#319
e413812 
)

This reverts commit 940f570.
safaiyeh pushed a commit that referenced this pull request Apr 27, 2021
@semantic-release-bot
chore(release): 3.1.3 [skip ci]
f2e7e15 
## [3.1.3](v3.1.2...v3.1.3) (2021-04-27)

### Bug Fixes

* **Android:** Revert "Read minSdkVersion from root project ([#314](#314))" ([#319](#319)) ([e413812](e413812))
@lecaro
Copy link

lecaro commented Apr 28, 2021

Thank you @safaiyeh !!!

@keremoge
Copy link
Contributor Author

I reopened a PR for a proper fix #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keremoge @safaiyeh @lecaro