-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using default framelength (Fixed IOS Crashes) #361
Using default framelength (Fixed IOS Crashes) #361
Conversation
DeepakM02
commented
Oct 18, 2021
- Prevent app crashing
- Using default frame length
ios/Voice/Voice.m
Outdated
@@ -224,7 +225,7 @@ - (void) setupAndStartRecognizing:(NSString*)localeStr { | |||
[mixer installTapOnBus:0 bufferSize:1024 format:recordingFormat block:^(AVAudioPCMBuffer * _Nonnull buffer, AVAudioTime * _Nonnull when) { | |||
//Volume Level Metering | |||
//Buffer frame can be reduced, if you need more output values | |||
[buffer setFrameLength: buffer.frameCapacity]; | |||
// [buffer setFrameLength: buffer.frameCapacity]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this a prop? so people can customize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@safaiyeh Do we need to set framelength?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, checked the previous commits looks like we don't need it. Lets clean up the code and delete the line & comments
Thanks @DeepakM02 left a couple comments |
clear logs and comments
@safaiyeh you can review this |
## [3.2.3](v3.2.2...v3.2.3) (2022-03-13) ### Bug Fixes * **iOS:** Using default framelength ([#361](#361)) ([8a6086a](8a6086a))
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |