Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Clarify that navigationType and isTopFrame is iOS only #1880

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

erkie
Copy link
Contributor

@erkie erkie commented Feb 16, 2021

These properties are either wrong or undefined for Android. I'll make a separate PR to try to include the hasGesture property which is similar to navigationType == click for Android.

@Titozzz Titozzz merged commit 9c51a17 into react-native-webview:master Mar 15, 2021
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 11.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

uspython added a commit to joycastle/react-native-webview that referenced this pull request Mar 17, 2021
* original_master: (94 commits)
  chore(release): 11.3.1 [skip ci]
  fix(windows): Check UAP contract version before calling FrameworkElement.IsLoaded (react-native-webview#1858)
  fix(android:) enable DRM protected content (react-native-webview#1862)
  chore(release): 11.3.0 [skip ci]
  feat(ios): Add support for `limitsNavigationsToAppBoundDomains` (react-native-webview#1662)
  chore(release): 11.2.6 [skip ci]
  fix(ios): Add missing nullability specifiers; fix if block warning (react-native-webview#1898)
  chore(release): 11.2.5 [skip ci]
  chore(docs): Clarify that navigationType and isTopFrame is iOS only (react-native-webview#1880)
  chore(docs): fixed "postMessage" url in Reference.md (react-native-webview#1913)
  fix(iOS): webview retain cycle (react-native-webview#1916)
  chore(release): 11.2.4 [skip ci]
  fix(iOS): Send cookies with resource requests (react-native-webview#1803)
  chore(release): 11.2.3 [skip ci]
  fix(android): Fix full=screen video when in modals (react-native-webview#1748 by @cristianoccazinsp)
  chore(release): 11.2.2 [skip ci]
  fix(windows): Resolve Deploy Issue (react-native-webview#1850)
  chore(ci): Upgrade react-native-windows to 0.62.17 (react-native-webview#1768)
  chore(release): 11.2.1 [skip ci]
  fix(ios): error on iOS < 13(react-native-webview#1843)
  ...
uspython added a commit to joycastle/react-native-webview that referenced this pull request Mar 17, 2021
* master: (186 commits)
  chore(release): 11.3.1 [skip ci]
  fix(windows): Check UAP contract version before calling FrameworkElement.IsLoaded (react-native-webview#1858)
  fix(android:) enable DRM protected content (react-native-webview#1862)
  chore(release): 11.3.0 [skip ci]
  feat(ios): Add support for `limitsNavigationsToAppBoundDomains` (react-native-webview#1662)
  chore(release): 11.2.6 [skip ci]
  fix(ios): Add missing nullability specifiers; fix if block warning (react-native-webview#1898)
  chore(release): 11.2.5 [skip ci]
  chore(docs): Clarify that navigationType and isTopFrame is iOS only (react-native-webview#1880)
  chore(docs): fixed "postMessage" url in Reference.md (react-native-webview#1913)
  fix(iOS): webview retain cycle (react-native-webview#1916)
  chore(release): 11.2.4 [skip ci]
  fix(iOS): Send cookies with resource requests (react-native-webview#1803)
  chore(release): 11.2.3 [skip ci]
  fix(android): Fix full=screen video when in modals (react-native-webview#1748 by @cristianoccazinsp)
  chore(release): 11.2.2 [skip ci]
  fix(windows): Resolve Deploy Issue (react-native-webview#1850)
  chore(ci): Upgrade react-native-windows to 0.62.17 (react-native-webview#1768)
  chore(release): 11.2.1 [skip ci]
  fix(ios): error on iOS < 13(react-native-webview#1843)
  ...

# Conflicts:
#	android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java
#	apple/RNCWebView.h
#	apple/RNCWebView.m
#	docs/Reference.md
#	index.d.ts
#	yarn.lock
bogdan-vol pushed a commit to railroadmedia/react-native-webview that referenced this pull request Mar 23, 2021
…t-native-webview

* 'master' of https://github.com/react-native-webview/react-native-webview:
  chore(docs): Update Instructions for Windows WebView Scrolling (react-native-webview#1927)
  chore(docs): Add multiDex error to the common issues section (react-native-webview#1921)
  chore(release): 11.3.1 [skip ci]
  fix(windows): Check UAP contract version before calling FrameworkElement.IsLoaded (react-native-webview#1858)
  fix(android:) enable DRM protected content (react-native-webview#1862)
  chore(release): 11.3.0 [skip ci]
  feat(ios): Add support for `limitsNavigationsToAppBoundDomains` (react-native-webview#1662)
  chore(release): 11.2.6 [skip ci]
  fix(ios): Add missing nullability specifiers; fix if block warning (react-native-webview#1898)
  chore(release): 11.2.5 [skip ci]
  chore(docs): Clarify that navigationType and isTopFrame is iOS only (react-native-webview#1880)
  chore(docs): fixed "postMessage" url in Reference.md (react-native-webview#1913)
  fix(iOS): webview retain cycle (react-native-webview#1916)
  chore(release): 11.2.4 [skip ci]
  fix(iOS): Send cookies with resource requests (react-native-webview#1803)
  chore(release): 11.2.3 [skip ci]
  fix(android): Fix full=screen video when in modals (react-native-webview#1748 by @cristianoccazinsp)
  chore(release): 11.2.2 [skip ci]
  fix(windows): Resolve Deploy Issue (react-native-webview#1850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants