You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When updating to the latest version (v5.4.1) I noticed that calling OnChange inside a plugin no longer assigns to existing data, it replaces them. This breaks some of the existing plugins. Not sure when this was introduced though.
To Reproduce
Steps to reproduce the behavior:
Go to https://react-page.github.io/ and play with the background plugin. Once you change anything, the data disappears and it only holds the latest change.
Expected behavior
I believe it should map onto existing data, if anything changed and is documented, we should probably at least fix the demo.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: ALL
Browser ALL
Version v5.4.1
The text was updated successfully, but these errors were encountered:
@macrozone I think you made some changes around these parts recently, you might have some extra info as to what happened there. I believe it's this code there are some changes compared to the old version that worked (that's the hook that creates the onChange method) that's causing trouble here. I am thinking this might have been an unintended sideffect of adding some i18n functionality? Don't really want to touch it right away as it seems you were after something. Better wait for your input. Cheers
Describe the bug
When updating to the latest version (v5.4.1) I noticed that calling OnChange inside a plugin no longer assigns to existing data, it replaces them. This breaks some of the existing plugins. Not sure when this was introduced though.
To Reproduce
Steps to reproduce the behavior:
Go to https://react-page.github.io/ and play with the background plugin. Once you change anything, the data disappears and it only holds the latest change.
Expected behavior
I believe it should map onto existing data, if anything changed and is documented, we should probably at least fix the demo.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: