Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Functional Component #987

Open
shegz101 opened this issue Feb 15, 2023 · 14 comments
Open

Upgrading to Functional Component #987

shegz101 opened this issue Feb 15, 2023 · 14 comments

Comments

@shegz101
Copy link

Is your feature request related to a problem? Please describe.
Trying to integrate into a project using Functional Components

Describe the solution you'd like
I was hoping there could be an upgrade for this to be compatible with projects that are using Functional Component. From the sample on how to import this tool, I noticed that it was done using Class Components, so I was thinking if we could upgrade it to FC.

Describe alternatives you've considered
Honestly, none.

Additional context
Add any other context or screenshots about the feature request here.

@jameswlane
Copy link
Collaborator

@shegz101 I can add this to the list of improvements.

Pull requests are always welcome. If you would like to put this together and do a PR, I would be more than happy to merge it.

@shegz101
Copy link
Author

Alright @jameswlane I will doing that and creating a PR for it.

@jameswlane
Copy link
Collaborator

@shegz101 Awesome, thank you.

I will move to fix the pipeline and move it from CircleCI to GitHub Actions to the top of my list for the repo.

@jameswlane
Copy link
Collaborator

@shegz101 I started fixing the build process in this PR

Just need to fix half the test and it should be good to merge to master. It would give you a working app to start with.

@shegz101
Copy link
Author

Alright, just keep me posted.

@jameswlane
Copy link
Collaborator

@shegz101 Once I get this fixed, I will have everything worked out. Emotion stopped working the way it used to. I have an issue open with them here

@jameswlane
Copy link
Collaborator

@shegz101, a friend (@murillomamud) of mine, came up with an alternative solution and will knock out a pr this weekend to fix the broken test till we figure out why emotion matchers are not working. The code repo should be ready to start working on by the end of the week.

@shegz101
Copy link
Author

Okay, when everything is up and running I can come in and do the upgrade then you can merge it. Thanks.

@jameswlane
Copy link
Collaborator

@shegz101 You should be good to go for adding functional components. 👍 Thank you for working on this.

@shegz101
Copy link
Author

Alright, I will look into it right away. Thanks.

@shegz101
Copy link
Author

@shegz101 You should be good to go for adding functional components. 👍 Thank you for working on this.

Hello James, I will look into this today. My system crashed that's the issue have been facing for a while now. Would get it working hopefully today. Thanks for understanding.

@jameswlane
Copy link
Collaborator

That sound's good. It's not a huge rush; real life happens sometimes.

@shegz101
Copy link
Author

That sound's good. It's not a huge rush; real life happens sometimes.

Alright.

@shegz101
Copy link
Author

shegz101 commented Apr 7, 2023

That sound's good. It's not a huge rush; real life happens sometimes.

Hello James, I just forked and cloned the repo. Looking forward to what's next. I would learn a lot via this contribution. It is my first open-source contribution and am so happy to be doing this, I would do everything it takes to learn a lot and get the issue fixed. Please, I will need your help a lot as I am new to lots of libraries used. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants