Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all exports are properly tested #23

Open
brodybits opened this issue Dec 17, 2021 · 0 comments
Open

not all exports are properly tested #23

brodybits opened this issue Dec 17, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@brodybits
Copy link
Collaborator

brodybits commented Dec 17, 2021

Some tests in src/packages/recompose/__tests__ test directly from individual modules rather than what would be exported from src/packages/recompose/index.js. This requires some extra files to be copied for CI dist & min dist testing.

Major bonus would be to export createFactory from src/packages/recompose/utils/createFactory.js & test this export as well.


P.S. I discovered that most but not all API modules in src/packages/recompose are re-exported by src/packages/recompose/index.js. I think it would be ideal to find a way to test import of most of the API items both from main index & from individual modules.

A major motivation has been to reduce the number of items copied during CI dist & min dist testing, and I would like to keep this as a major goal.

@brodybits brodybits added the bug Something isn't working label Dec 17, 2021
@brodybits brodybits self-assigned this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant