Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist Recompose.min.js build is not really minimized #55

Open
brodybits opened this issue Mar 1, 2023 · 0 comments · May be fixed by #56 or #54
Open

dist Recompose.min.js build is not really minimized #55

brodybits opened this issue Mar 1, 2023 · 0 comments · May be fixed by #56 or #54
Assignees
@brodybits
Labels
bug Something isn't working

Comments

@brodybits
Copy link
Collaborator

After trying some Rollup plugin updates, I discovered that the generated Recompose.min.js is not really minimized. Here is what I would get from ls -l lib/packages/recompose/dist:

-rw-r--r--  1 brodybits  staff  33348 Mar  1 10:21 Recompose.cjs.js
-rw-r--r--  1 brodybits  staff  32184 Mar  1 10:21 Recompose.esm.js
-rw-r--r--  1 brodybits  staff  42901 Mar  1 10:21 Recompose.min.js
-rw-r--r--  1 brodybits  staff  45937 Mar  1 10:21 Recompose.umd.js

Updating rollup-plugin-uglify to version 6 gives me generated Recompose.min.js under 15K, similar to switching to @rollup/plugin-terser as I proposed in PR #54.
@brodybits brodybits added the bug Something isn't working label Mar 1, 2023
@brodybits brodybits self-assigned this Mar 1, 2023
This was referenced Mar 1, 2023
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brodybits brodybits

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@brodybits