changed index.jsx class to functional #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
thanks @rohit-yadavv we will review the code |
|
@rohit-yadavv did you tried running the example in local? |
|
@ansulagrawal No, i haven't setup project locally i just changed file from class based to functional |
|
@ansulagrawal I will check it locally and will update you soon |
| class Scheduler extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| function Scheduler(props) { |
There was a problem hiding this comment.
Function Scheduler has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 5b4c6ac and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
@rohit-yadavv did you check in the local, is it working? |
|
@rohit-yadavv I didn't heard from you anyting so I am closing this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #85
![Uploading image.png…]()
![Uploading image.png…]()
made src/components/index.js from class to functional component