-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Firefox support #109
Comments
Not at this time, perhaps after we fix all the outstanding bugs we can look into porting it to Firefox. It shouldn't be too difficult to port, but I haven't played around with firefox extensions myself |
@GuillaumeAmat Hey 👋! I actually did this! As someone who has recently switched to Firefox, I was curious how feasible this would be. Turns out it's incredibly easy, since Firefox and Chrome use the same browser extension standards. Here is the PR to add Firefox support: #178. I will follow up with a documentation update with clear instructions on how to use this in Firefox. Additionally, it is currently pending review on the Firefox addon website. |
Wow! Two releases in one day! Two year ago someone requested support for Firefox in this thread: #109 Well, I finally got around to looking into this, and it turned out to be incredibly easy. Essentially all that needed to be changed were a few (misconfigured) settings in `manifest.json`, fully switching from `chrome.extension` to `chrome.runtime`, and passing an empty string into `chrome.devtools.panels.create` for the icons parameter. Turns out `null` will actually throw an error in Firefox!
Wow! Two releases in one day! Two year ago someone requested support for Firefox in this thread: #109 Well, I finally got around to looking into this, and it turned out to be incredibly easy. Essentially all that needed to be changed were a few (misconfigured) settings in `manifest.json`, fully switching from `chrome.extension` to `chrome.runtime`, and passing an empty string into `chrome.devtools.panels.create` for the icons parameter. Turns out `null` will actually throw an error in Firefox!
Wow! Two releases in one day! Two year ago someone requested support for Firefox in this thread: #109 Well, I finally got around to looking into this, and it turned out to be incredibly easy. Essentially all that needed to be changed were a few (misconfigured) settings in `manifest.json`, fully switching from `chrome.extension` to `chrome.runtime`, and passing an empty string into `chrome.devtools.panels.create` for the icons parameter. Turns out `null` will actually throw an error in Firefox!
Updated docs here: #179. I will close this when it's released on the Firefox addon page. |
Live! https://addons.mozilla.org/en-US/firefox/addon/react-sight/ I will close this issue now |
Great thanks @davidcsally ! ❤️ Though, it seems that I have the #134 issue... It does not work on remote or local React websites. Also, the last version of react-sight is 1.2.0 but I only see the 1.1.0 on the Mozilla addon page. |
It’s actually the correct version at Mozilla, but I forgot to bump the version number 😬. Expect a 1.2.1 soon. I’m waiting for the chrome approval before I bump again. As for the error, I’ll test some more today. I think there is a major issue with React 16, where React will not be detected until something re-renders |
This has been released! |
Is there a plan to support Firefox too?
The text was updated successfully, but these errors were encountered: