Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #126

Open
Gustl22 opened this issue Mar 4, 2021 · 3 comments
Open

Localization #126

Gustl22 opened this issue Mar 4, 2021 · 3 comments

Comments

@Gustl22
Copy link

Gustl22 commented Mar 4, 2021

If using localization, themes must be combined with Locale:
https://material-ui.com/guides/localization/

Can you provide a method, which takes a Theme Object (e.g. created by createMuiTheme) instead of the raw Palette. Thx :)

@usulpro
Copy link
Member

usulpro commented Mar 4, 2021

We can't pass it between panel and stories because it's not serializable. What if we provide ability to specify localisation additionally

@usulpro
Copy link
Member

usulpro commented Mar 4, 2021

Additionally you can have a look at https://github.com/react-theming/storybook-addon addon. It gives you more flexibility on creating providers

@Gustl22
Copy link
Author

Gustl22 commented Mar 4, 2021

I understand. If you want you can provide an extra param for the locale. But using the other provided lib worked just fine, thank you! Can be closed, or kept open for possible implementation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants