Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop warnings for themeName and themeNameArr #50

Closed
hoschi opened this issue Feb 6, 2017 · 6 comments
Closed

Prop warnings for themeName and themeNameArr #50

hoschi opened this issue Feb 6, 2017 · 6 comments

Comments

@hoschi
Copy link

hoschi commented Feb 6, 2017

I updated my dependcies:

-    "@kadira/storybook": "2.20.1",
+    "@kadira/storybook": "2.35.3",
-    "storybook-addon-material-ui": "0.7.2",
+    "storybook-addon-material-ui": "0.7.5",
-    "material-ui": "0.15.4",
+    "material-ui": "0.16.7",
-    "react": "15.3.1",
-    "react-dom": "15.3.1",
+    "react": "15.4.2",
+    "react-dom": "15.4.2",
-    "react-tap-event-plugin": "1.0.0",
+    "react-tap-event-plugin": "2.0.1",

Now I get warnings about props not passed to MuiTheme component:
2017-02-06-171730_1303x1384_scrot

I checked the component https://github.com/sm-react/storybook-addon-material-ui/blob/196e7c4a6bfd0c175666e00da2c7e4aa955b595d/src/containers/MuiTheme.js#L15
But it seems it doesn't do anything with them. Also my theme name and settings are visible in the panes added from your addon.

@joshjconlin
Copy link
Contributor

removing both of those props from MuiTheme.js seems to fix the error

@hoschi
Copy link
Author

hoschi commented Feb 7, 2017

sure, the question is: are these props really required or not. My quick code scan give me the opinion they are not used.

@usulpro
Copy link
Member

usulpro commented Feb 7, 2017

Yes, we don't need them for now.
Thank you!

@hoschi
Copy link
Author

hoschi commented Feb 7, 2017

I'll test it when it is released.

@usulpro
Copy link
Member

usulpro commented Feb 7, 2017

@hoschi, @joshjconlin! v0.7.6 is avalible on npm. No warnings in console should be

@hoschi
Copy link
Author

hoschi commented Feb 7, 2017

works, thank you

@hoschi hoschi closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants