-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prop warnings for themeName and themeNameArr #50
Comments
removing both of those props from MuiTheme.js seems to fix the error |
sure, the question is: are these props really required or not. My quick code scan give me the opinion they are not used. |
Merged
Yes, we don't need them for now. |
I'll test it when it is released. |
@hoschi, @joshjconlin! v0.7.6 is avalible on npm. No warnings in console should be |
works, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I updated my dependcies:
Now I get warnings about props not passed to MuiTheme component:
![2017-02-06-171730_1303x1384_scrot](https://cloud.githubusercontent.com/assets/163128/22655339/27b5527a-ec90-11e6-9fa1-cdac1324c9b9.png)
I checked the component https://github.com/sm-react/storybook-addon-material-ui/blob/196e7c4a6bfd0c175666e00da2c7e4aa955b595d/src/containers/MuiTheme.js#L15
But it seems it doesn't do anything with them. Also my theme name and settings are visible in the panes added from your addon.
The text was updated successfully, but these errors were encountered: