Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date and time picker have hardcoded placeholders #117

Closed
adamscybot opened this issue Nov 16, 2015 · 5 comments
Closed

Date and time picker have hardcoded placeholders #117

adamscybot opened this issue Nov 16, 2015 · 5 comments

Comments

@adamscybot
Copy link

Just noticed that the placeholder for the time and date picker fields is hardcoded to

placeholder='Pick up date'

and

placeholder='Pick up time'

Presumably, this should be configurable.

@javivelasco
Copy link
Member

You are right! Thanks for reporting, fixing asap

@soyjavi
Copy link
Contributor

soyjavi commented Nov 17, 2015

Thanks for the report, we will fix today.

@soyjavi soyjavi added the fixed label Nov 17, 2015
@soyjavi
Copy link
Contributor

soyjavi commented Nov 17, 2015

@soyjavi soyjavi closed this as completed Nov 17, 2015
@gundlev
Copy link

gundlev commented Nov 23, 2015

The placeholder for TimePicker still seems to be hardcoded. I know its been reported only a few days ago, but the issue was marked as fixed and it still seems to be a problem. The DatePicker seems to be working perfectly though!

@javivelasco
Copy link
Member

Yes, you're right. Let's reopen to remember to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants