Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx extension vs js #258

Closed
giltig opened this issue Jan 10, 2016 · 7 comments
Closed

jsx extension vs js #258

giltig opened this issue Jan 10, 2016 · 7 comments
Assignees
@javivelasco
Labels
Type: Enhancement

Comments

@giltig
Copy link

giltig commented Jan 10, 2016

Hi,
Your components are with jsx extensions.
I would recommend to change it to normal js extensions due to the fact that jsx is now another transpiled feature of the new js (such as many more of es2015, es 2016 etc.).
@EnzoMartin
Copy link
Contributor

Why? What advantage does not using JSX give?

@giltig
Copy link
Author

giltig commented Jan 10, 2016

It's a matter of convention. jsx today is just part of js and Facebook also recommended that js extension will be the convention also for jsx files.
facebook/react#3582 (comment)

@javivelasco
Copy link
Member

Yes, truth is I'm writing no jsx extension anymore. Doing it tonight!

@javivelasco javivelasco self-assigned this Jan 11, 2016
@nathanmarks
Copy link
Contributor

Ah, the ever changing practices :)

@EnzoMartin
Copy link
Contributor

It's Facebook, so that's gonna happen quite often sadly

@KerenChandran
Copy link
Contributor

@javivelasco I think we can close this issue since its implemented in 0cb8d8b

@javivelasco
Copy link
Member

Yep, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javivelasco javivelasco

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@EnzoMartin @javivelasco @nathanmarks @giltig @KerenChandran