-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cant resolve module 'babel' when running dist #301
Comments
|
But the server doesn´t get the env.process.PORT variable set. Is that outside of the scope of the implemented server, or can I use that server for dist? |
IMO there are two answers to this question. Setting the port through an ENV var: Setting the port is a planned feature that I hope to implement soon. You could subscribe to react-webpack-generators/react-webpack-template#68 (and also +1 it if you feel it would be helpful). Using the server for running in production: Besides the port issue, |
Okey, as a tip for improvement I would strongly suggest putting this info about deployment in the documents! |
@AlfredOdling that's a good suggestion, I have added an issue for that (#311) and hope to update it along with the next release. |
Im trying to deploy my app and been trying so hard to do it. I dont get it, it should pretty straightforward to do this right? How do you deploy to heroku? Im telling heroku to run: "npm run dist && npm run start". Please check my question on stackoverflow: http://stackoverflow.com/questions/40637447/cant-resolve-module-babel-when-running-dist
The text was updated successfully, but these errors were encountered: