-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-side routing #6
Comments
I +1 this big time! I have been putting out the feelers to what the community use and the general consensus I feel is whatever suits. As an example from the MeteorJS community, Iron Router is freaking ace! It's key-concepts are worth looking at and I think a react specific router using this as a reference would be a great library for development. |
The reason we haven't come up with a great one is because we would want it to work on both server and client transparently. But that makes the problem a lot more complicated and we can incrementally get there by starting on client-only first. One example is what we do in todomvc: https://github.com/tastejs/todomvc/blob/gh-pages/labs/architecture-examples/react/js/app.jsx#L31. But if Iron Router is better we can use that. |
react-router seems to hit the nail on the head with all the requirements http://andreypopp.viewdocs.io/react-router-component |
@ryanseddon I agree and I will try and set aside some time to integrate into this generator as an optional include (unless someone else beats me to it 🐎 ) |
How does the routing work currently? I see paths that the browser interprets as "script/components" which sets relative paths to ../../styles/ so its seemingly 1:1 from the filesystem. |
Done :) @petehunt etc |
Sorry to comment on such an old issue, but is this |
Hi @RobErskine, the generator does not have support for flux or react-router anymore. This was done in version 2.0, because we wanted it to be easier to maintain (see https://github.com/newtriks/generator-react-webpack#changes-in-version-20). For flux frameworks, there are currently at least 2 other generators using generator-react-webpack as base (reflux and alt.js). Both are linked to in the README. Installing react-router is easy as:
Hope this helps. |
Thanks @weblogixx, that's great. I didn't realize react-router was part of the flux strip out overhaul done in 2.0. |
Would be cool if there was a React router that was in npm installable and was set up out-of-the-box by the generator
The text was updated successfully, but these errors were encountered: