Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Error when store name is changed. #11

Open
mayank1513 opened this issue Dec 30, 2023 · 0 comments
Open

Throw Error when store name is changed. #11

mayank1513 opened this issue Dec 30, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mayank1513
Copy link
Member

mayank1513 commented Dec 30, 2023

Is your feature request related to a problem? Please describe.
The name of the persistent store can not be changed, as it is used before the state is loaded.

Describe the solution you'd like

  1. Create an interface for __persistNSyncOptions. This interface should not include name.
  2. Throw an error when name is changed.
  3. Always read option.name and not prevState.__persistNSyncOptions.name

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@mayank1513 mayank1513 added the good first issue Good for newcomers label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant