Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming the generated Builder class #60

Closed
realityforge opened this issue May 28, 2020 · 1 comment
Closed

Consider renaming the generated Builder class #60

realityforge opened this issue May 28, 2020 · 1 comment
Labels
api_change Changes the API of components enhancement

Comments

@realityforge
Copy link
Member

If you define a component MyComponent, the annotation processor will generate a builder named MyComponentBuilder. Another option is to name the builder MyComponents which is shorter and somewhat easier to use.

However, this change would be a lot of churn for limited value so only do this pre 1.0 and only if we can automate the transform and/or chunk it with other wide-ranging changes.

@realityforge realityforge added enhancement api_change Changes the API of components labels May 28, 2020
@realityforge
Copy link
Member Author

While this request comes up frequently enough, mostly with the desire to shrink code I am not sure it is worth it. Almost certainly we would want "correct" pluralization would would mean somehow configuring it for weird cases and I just don't think a few characters less is worth the increase in complexity, especially as autocomplete works well enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api_change Changes the API of components enhancement
Development

No branches or pull requests

1 participant